tests/main/sudo-env: check snap path under sudo #8875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some distributions set secure_path in /etc/sudoers which resets the PATH under sudo to some predefined set of locations. Make sure to account for all distros supported by snapd that have sudo set up this way. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/sudo-env
branch
from
c58d713
to
809bc87
Compare
zyga
reviewed
Jun 16, 2020
tests/main/sudo-env/task.yaml
Outdated
| . "$TESTSLIB/dirs.sh" | ||
|
|
||
| # run a snap command via sudo | ||
| su -l -c "sudo sh -c 'echo :\$PATH:'" test > sudo.path |
There was a problem hiding this comment.
Please use tests.session, su -l will give you a login shell and may trigger PAM.
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
zyga
reviewed
Jun 16, 2020
| tests.session -u test exec sudo sh -c 'echo :$PATH:' test > sudo.path | ||
| # and again via sudo --login which should load /etc/profile | ||
| # shellcheck disable=SC2016 | ||
| tests.session -u test exec sudo --login sh -c 'echo :$PATH:' > sudo-login.path |
There was a problem hiding this comment.
I missed this part before. I wonder if this would cause root's session to start (and tear down in a moment).
zyga
approved these changes
Jun 16, 2020
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
tests/main/sudo-env/task.yaml
Outdated
|
|
||
| # run a snap command via sudo | ||
| # shellcheck disable=SC2016 | ||
| tests.session -u test exec sudo sh -c 'echo :$PATH:' test > sudo.path |
There was a problem hiding this comment.
what's with the errant test towards the end here? I am having a difficult time telling which command that is an argument too, I think this would be more clear with some -- sprinkled in. ❇️
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some distributions set secure_path in /etc/sudoers which resets the PATH
under sudo to some predefined set of locations. Make sure to account for all
distros supported by snapd that have sudo set up this way.